feat(aci): automation edit scaffolding

[ameliahsu]

• added automation form to the automation edit view
• the form + AutomationBuilderReducer are now able to use an existing automation to populate the form fields
• setting up the edit actions (save + delete) will come in the next PR

we can also remove flattie now since we're maintaining automation builder state outside of the form

[scttcper]

this is difficult to read

[cursor]

Bug: State Initialization Vulnerabilities in AutomationBuilder

The AutomationBuilderState initialization in edit.tsx has two issues. Firstly, actionFilters is directly assigned automation.actionFilters without a fallback to a default array (unlike triggers), which can result in actionFilters being undefined and violating its expected array type. Secondly, the useAutomationBuilderReducer hook is initialized with initialState derived from automation. Although the current conditional rendering prevents the reducer from being initialized with an undefined state (as the form only mounts after automation data loads), this pattern is fragile and could lead to an empty default state if loading conditions change.

static/app/views/automations/edit.tsx#L81-L95

sentry/static/app/views/automations/edit.tsx

Lines 81 to 95 in b159165

	const initialState = useMemo((): AutomationBuilderState | undefined => {
	if (!automation) {
	return undefined;
	}
	return {
	triggers: automation.triggers
	? automation.triggers
	: initialAutomationBuilderState.triggers,
	actionFilters: automation.actionFilters,
	};
	}, [automation]);
	const model = useMemo(() => new FormModel(), []);
	const {state, actions} = useAutomationBuilderReducer(initialState);

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎