Skip to content

feat(dashboards): add sorting to non-issues table widgets #94884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

lzhao-sentry
Copy link
Contributor

@lzhao-sentry lzhao-sentry commented Jul 3, 2025

Changes

This is part two of this PR: #94570

Enable sorting for table widget visualization used in dashboards. This feature is only visible to perf since the table is hidden behind a feature flag.

Note that issues table widget has been omitted for now. Mainly due to the restriction the fields have (e.g., only being able to sort one direction) and inconsistencies with direction.

Videos

Sorting on the dashboard

sorting1.mov

Sorting in widget builder preview

sorting2.mov

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jul 3, 2025
@lzhao-sentry lzhao-sentry marked this pull request as ready for review July 3, 2025 19:40
@lzhao-sentry lzhao-sentry requested a review from a team as a code owner July 3, 2025 19:40
@lzhao-sentry lzhao-sentry changed the title ref(dashboards): add sorting to non-issues table widgets feat(dashboards): add sorting to non-issues table widgets Jul 3, 2025
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me but gonna defer to @gggritso for a final stamp

@gggritso
Copy link
Member

gggritso commented Jul 3, 2025

@nikkikapadia but I was going to defer to you for the final stamp!

Copy link
Member

@nikkikapadia nikkikapadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gggritso if i must 😌

@lzhao-sentry lzhao-sentry merged commit 8dd9582 into master Jul 3, 2025
46 checks passed
@lzhao-sentry lzhao-sentry deleted the lzhao/ref/enable-sorting-in-dashboards-table branch July 3, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants