Skip to content

feat(aci): Parse query eventTypes out to snuba query #97940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

scttcper
Copy link
Member

We want to save eventTypes to the snuba query model, however we aren't going to add a dropdown like metric alerts has. This parses the query string and puts the result in snubaQuery.eventTypes to be saved and puts them back in the query when hitting the stats api.

@scttcper scttcper requested a review from a team as a code owner August 15, 2025 18:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11443 1 11442 10
View the top 1 failed test(s) by shortest run time
DetectorEdit Metric Detector can submit a new metric detector with event.type:error
Stack Traces | 5.43s run time
Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at it (.../views/detectors/new-setting.spec.tsx:163:5)
    at _dispatchDescribe (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:604:26)
    at describe (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:572:44)
    at describe (.../views/detectors/new-setting.spec.tsx:88:3)
    at _dispatchDescribe (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:604:26)
    at describe (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:572:44)
    at Object.describe (.../views/detectors/new-setting.spec.tsx:12:1)
    at Runtime._execModule (.../sentry/node_modules/.pnpm/jest-runtime@30.0..../jest-runtime/build/index.js:1264:24)
    at Runtime._loadModule (.../sentry/node_modules/.pnpm/jest-runtime@30.0..../jest-runtime/build/index.js:940:12)
    at Runtime.requireModule (.../sentry/node_modules/.pnpm/jest-runtime@30.0..../jest-runtime/build/index.js:828:12)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:95:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant