fix(crons): Don't drop invalid schema when writing checkin rows #97945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug where we accidentally didn't save all the required fields for the monitor config. This causes a bug when we copy the config over to the monitor checkin where we end up storing a null value. We should instead treat this as a warning - if the config is already stored in the monitor, it should be replicated regardless of whether it's valid or not. The validation should happen at mutation time, which is being fixed in #97943 Fixes SENTRY-4DDN
github-actions
bot
added
the
Scope: Backend
wedamija
commented
Aug 15, 2025
Comment on lines
+375
to
+376
| # We should always return the config here - just log an error if we detect that it doesn't | ||
| # match the schema |
There was a problem hiding this comment.
To some extent I wonder if this validation is even useful at this step... I guess it's good to know if somehow invalid configs are getting into the system so we can fix them
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97945 +/- ##
==========================================
+ Coverage 79.55% 80.63% +1.08%
==========================================
Files 8593 8595 +2
Lines 379066 379155 +89
Branches 24700 24700
==========================================
+ Hits 301558 305728 +4170
+ Misses 77130 73049 -4081
Partials 378 378 |
gaprl
approved these changes
Aug 15, 2025
evanh
pushed a commit
that referenced
this pull request
Aug 18, 2025
We had a bug where we accidentally didn't save all the required fields for the monitor config. This causes a bug when we copy the config over to the monitor checkin where we end up storing a null value. We should instead treat this as a warning - if the config is already stored in the monitor, it should be replicated regardless of whether it's valid or not. The validation should happen at mutation time, which is being fixed in #97943 Fixes SENTRY-4DDN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug where we accidentally didn't save all the required fields for the monitor config. This causes a bug when we copy the config over to the monitor checkin where we end up storing a null value.
We should instead treat this as a warning - if the config is already stored in the monitor, it should be replicated regardless of whether it's valid or not. The validation should happen at mutation time, which is being fixed in #97943
Fixes SENTRY-4DDN