Skip to content

Conversation

malwilley
Copy link
Member

@malwilley malwilley commented Aug 15, 2025

When the workflow-engine-metric-detector-limit flag is on and the subscription metric detector limit is exceeded, will disable creation of new ones.

CleanShot 2025-08-15 at 13 16 16@2x

@malwilley malwilley requested review from leedongwei and a team August 15, 2025 20:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 15, 2025
Copy link

codecov bot commented Aug 15, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
11518 1 11517 10
View the top 1 failed test(s) by shortest run time
useMetricDetectorLimit handles missing X-Hits header as error
Stack Traces | 0.088s run time
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 1

  Object {
    "detectorCount": -1,
    "detectorLimit": 5,
    "hasReachedLimit": false,
-   "isError": true,
+   "isError": false,
    "isLoading": false,
  }
    at Object.toEqual (.../gsApp/hooks/useMetricDetectorLimit.spec.tsx:277:28)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@leedongwei leedongwei marked this pull request as ready for review August 19, 2025 23:56
@leedongwei leedongwei requested review from a team as code owners August 19, 2025 23:56
describe('useMetricDetectorLimit', () => {
beforeEach(() => {
MockApiClient.clearMockResponses();
queryClient.clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear works but could probably make a whole new queryClient on every render

@malwilley malwilley merged commit 3c02484 into master Aug 25, 2025
45 checks passed
@malwilley malwilley deleted the malwilley/feat/metric-alert-quota branch August 25, 2025 17:18
andrewshie-sentry pushed a commit that referenced this pull request Aug 26, 2025
When the `workflow-engine-metric-detector-limit` flag is on and the
subscription metric detector limit is exceeded, will disable creation of
new ones.
Copy link

sentry-io bot commented Aug 27, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ [**Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�...** in ci:pull_request

Did you find this useful? React with a 👍 or 👎

constantinius pushed a commit that referenced this pull request Sep 1, 2025
When the `workflow-engine-metric-detector-limit` flag is on and the
subscription metric detector limit is exceeded, will disable creation of
new ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants