-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(replay): Fix continuous profiling in replay recording consumer, send profiling data to separate internal project #97964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97964 +/- ##
==========================================
- Coverage 80.63% 80.62% -0.02%
==========================================
Files 8593 8605 +12
Lines 378847 379853 +1006
Branches 24666 24666
==========================================
+ Hits 305493 306244 +751
- Misses 72985 73240 +255
Partials 369 369 |
ryan953
reviewed
Aug 15, 2025
ryan953
reviewed
Aug 15, 2025
ryan953
reviewed
Aug 15, 2025
ryan953
reviewed
Aug 15, 2025
cmanallen
requested changes
Aug 25, 2025
cmanallen
approved these changes
Aug 27, 2025
kenzoengineer
pushed a commit
that referenced
this pull request
Aug 28, 2025
…end profiling data to separate internal project (#97964) fixes REPLAY-592 - Move continuous profiling calls out of the transaction - Send continuous profiling data to separate internal project with dsn `SENTRY_REPLAY_RECORDINGS_CONSUMER_PROFILING_PROJECT_DSN` - Only profile if: - `replay.consumer.recording.profiling.enabled` option is enabled - traces and profile session sample rates are nonzero - DSN is not None
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 28, 2025
…end profiling data to separate internal project (#97964) fixes REPLAY-592 - Move continuous profiling calls out of the transaction - Send continuous profiling data to separate internal project with dsn `SENTRY_REPLAY_RECORDINGS_CONSUMER_PROFILING_PROJECT_DSN` - Only profile if: - `replay.consumer.recording.profiling.enabled` option is enabled - traces and profile session sample rates are nonzero - DSN is not None
constantinius
pushed a commit
that referenced
this pull request
Sep 1, 2025
…end profiling data to separate internal project (#97964) fixes REPLAY-592 - Move continuous profiling calls out of the transaction - Send continuous profiling data to separate internal project with dsn `SENTRY_REPLAY_RECORDINGS_CONSUMER_PROFILING_PROJECT_DSN` - Only profile if: - `replay.consumer.recording.profiling.enabled` option is enabled - traces and profile session sample rates are nonzero - DSN is not None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes REPLAY-592
SENTRY_REPLAY_RECORDINGS_CONSUMER_PROFILING_PROJECT_DSN
replay.consumer.recording.profiling.enabled
option is enabled