Skip to content

Add Django performance review skill#31

Merged
gricha merged 2 commits intomainfrom
security-review-revamp
Jan 30, 2026
Merged

Add Django performance review skill#31
gricha merged 2 commits intomainfrom
security-review-revamp

Conversation

@gricha
Copy link
Member

@gricha gricha commented Jan 30, 2026

Summary

  • Adds Django performance review skill for finding N+1 queries, unbounded querysets, missing indexes, and write loops

Changes

  • Prioritized issue categories (N+1, unbounded querysets, missing indexes, write loops, missing prefetch)
  • Validation requirements to reduce false positives
  • Clear guidance on what NOT to report

Test plan

  • Run /django-perf-review on Django codebase
  • Verify skill appears in claude-settings-audit allowlist

Add skill for reviewing Django code for validated performance issues:
- N+1 queries with full data flow tracing
- Unbounded querysets and pagination
- Missing database indexes
- Write loops (bulk_create/update patterns)
- Missing prefetch on single object fetches

Includes validation requirements and false positive guidance to ensure
only real, impactful issues are reported.

Co-Authored-By: Claude <noreply@anthropic.com>
@gricha gricha changed the title Expand security review and add Django performance review skill Add Django performance review skill Jan 30, 2026
@gricha gricha marked this pull request as ready for review January 30, 2026 21:06
- Add missing quotes around skill name in JSON example
- Remove "Missing Prefetch on Single Object" category - 2 queries vs 1
  on a single fetch is a micro-optimization not worth reporting
- Add explicit guidance in "What NOT to Report" section

Co-Authored-By: Claude <noreply@anthropic.com>
@gricha gricha merged commit 4883564 into main Jan 30, 2026
3 checks passed
@gricha gricha deleted the security-review-revamp branch January 30, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant