-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix: add cleanup handlers for EventSource connection in cli tail #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊❌ Patch coverage is 100.00% with 1348 lines missing coverage. Files with missing lines (31)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 76.31% 76.31% —%
==========================================
Files 47 47 —
Lines 5690 5690 —
Branches 614 611 -3
==========================================
+ Hits 4342 4342 —
- Misses 1348 1348 —
- Partials 5 5 —Generated by Codecov Action |
|
Hi @Shubhdeep12 can you provide a short description about why this was needed? Were we stalling process exit? |
|
Also curious how these play together with the existing signal handlers |
yeah whenever spotlight tail runs and connects to upstream - a new connection gets created but on exiting its not cleared.. |
On running spotlight tail before creating a server (
setupSidecar) - we check if any instance of sidecar is already running(connectUpstream)if yes, we just create a connection to that upstream.
Note: when main upstream sidecar is exited, i guess all connections are closed by
server.closeAllConnections();