Skip to content

Conversation

@Shubhdeep12
Copy link
Collaborator

@Shubhdeep12 Shubhdeep12 commented Jan 20, 2026

On running spotlight tail before creating a server (setupSidecar) - we check if any instance of sidecar is already running(connectUpstream)
if yes, we just create a connection to that upstream.

  • but we missed adding signal handlers for this new connection.

Note: when main upstream sidecar is exited, i guess all connections are closed by server.closeAllConnections();

@vercel
Copy link

vercel bot commented Jan 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
spotlightjs Skipped Skipped Jan 20, 2026 2:03pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Added new codecov action by MathurAditya724 in #1255

Bug Fixes 🐛

  • (cli) Show options in command-specific help output by BYK in #1260
  • (deps) Address Dependabot security alerts by BYK in #1261
  • Add cleanup handlers for EventSource connection in cli tail by Shubhdeep12 in #1258
  • Updated the codecov action to point to getsentry by MathurAditya724 in #1259

Internal Changes 🔧

  • (ci) Fix workflow warnings for cache action and codecov by BYK in #1251
  • (deps) Bump hono from 4.10.3 to 4.11.4 by dependabot in #1254
  • (release) Fix Docker Latest Target by BYK in #1252
  • Use pull_request_target for changelog preview by BYK in #1256

Other

  • Update documentation link in README.md by sergical in #1253

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

Codecov Results 📊

❌ Patch coverage is 100.00% with 1348 lines missing coverage.
✅ Project coverage is 76.31%. Comparing base (base) to head (head).

Files with missing lines (31)
File Patch % Lines
event.ts 52.61% ⚠️ 263 Missing
mcp.ts 65.91% ⚠️ 151 Missing
messageBuffer.ts 67.57% ⚠️ 120 Missing
docker-compose.ts 77.33% ⚠️ 85 Missing
utils.ts 31.71% ⚠️ 84 Missing
extras.ts 28.13% ⚠️ 69 Missing
debugLogging.ts 29.47% ⚠️ 67 Missing
utils.ts 75.28% ⚠️ 66 Missing
index.ts 24.59% ⚠️ 46 Missing
cors.ts 91.08% ⚠️ 39 Missing and 1 partials
logs.ts 28.85% ⚠️ 37 Missing
traces.ts 93.10% ⚠️ 33 Missing and 1 partials
userAgent.ts 52.63% ⚠️ 27 Missing
index.ts 80.47% ⚠️ 25 Missing
utils.ts 66.67% ⚠️ 23 Missing
errors.ts 75.53% ⚠️ 23 Missing
JsonViewer.tsx 71.62% ⚠️ 21 Missing
traces.ts 75.86% ⚠️ 21 Missing
processEnvelope.ts 86.67% ⚠️ 18 Missing
eventContainer.ts 78.05% ⚠️ 18 Missing
open.ts 42.86% ⚠️ 16 Missing
CodeViewer.tsx 54.55% ⚠️ 15 Missing
contentType.ts 66.67% ⚠️ 15 Missing
Attachment.tsx 90.00% ⚠️ 12 Missing and 1 partials
helpers.ts 70.27% ⚠️ 11 Missing
streaming.ts 76.09% ⚠️ 11 Missing
ShikiProvider.tsx 54.17% ⚠️ 11 Missing
AnsiText.tsx 91.00% ⚠️ 9 Missing
logger.ts 65.22% ⚠️ 8 Missing
logger.ts 87.50% ⚠️ 4 Missing and 1 partials
profileChunkProcessor.ts 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    76.31%    76.31%        —%
==========================================
  Files           47        47         —
  Lines         5690      5690         —
  Branches       614       611        -3
==========================================
+ Hits          4342      4342         —
- Misses        1348      1348         —
- Partials         5         5         —

Generated by Codecov Action

@BYK
Copy link
Member

BYK commented Jan 21, 2026

Hi @Shubhdeep12 can you provide a short description about why this was needed? Were we stalling process exit?

@BYK
Copy link
Member

BYK commented Jan 21, 2026

Also curious how these play together with the existing signal handlers

@Shubhdeep12
Copy link
Collaborator Author

Hi @Shubhdeep12 can you provide a short description about why this was needed? Were we stalling process exit?

yeah whenever spotlight tail runs and connects to upstream - a new connection gets created but on exiting its not cleared..

@Shubhdeep12 Shubhdeep12 requested a review from BYK January 25, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants