Feat(spotlight): metrics support #1265
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 1476 uncovered lines. Files with missing lines (32)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 76.31% 75.18% -1.13%
==========================================
Files 47 48 +1
Lines 5690 5946 +256
Branches 611 614 +3
==========================================
+ Hits 4342 4470 +128
- Misses 1348 1476 +128
- Partials 5 5 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| > | ||
| {type} | ||
| </span> | ||
| ); |
There was a problem hiding this comment.
Duplicate MetricTypeBadge component in two files
Low Severity
The MetricTypeBadge component is identically defined in both MetricDetail.tsx and MetricsList.tsx. Both implementations have the same props, the same color mappings for counter/gauge/distribution, and the same rendering logic. This duplication increases maintenance burden and risks inconsistent bug fixes if either copy needs to be modified.
Additional Locations (1)
| min: Math.min(...values), | ||
| max: Math.max(...values), | ||
| count: metrics.length, | ||
| }; |
There was a problem hiding this comment.
Duplicate switch case logic for gauge and distribution
Low Severity
The aggregateMetrics function has identical implementations for the gauge and distribution switch cases. Both return the same properties (sum, avg, min, max, count) calculated in the same way, creating unnecessary code duplication.
| getMetricsByName: (name: string) => { | ||
| return get().metricsByName.get(name) || []; | ||
| }, | ||
| getMetricNames: () => Array.from(get().metricsByName.keys()), |
There was a problem hiding this comment.
Unused getMetricsByName and getMetricNames functions
Low Severity
The getMetricsByName and getMetricNames functions are defined in the metrics slice and typed in the store types, but they are never called anywhere in the codebase. These are dead code that add unnecessary complexity and maintenance burden without providing value.
Additional Locations (1)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| {type} | ||
| </span> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Duplicated MetricTypeBadge component across two files
Low Severity
The MetricTypeBadge component is defined identically in both MetricsList.tsx and MetricDetail.tsx. Both implementations have the same props, color mappings, and JSX structure. This duplicated logic increases maintenance burden and risks inconsistent bug fixes if changes are needed in the future.
Additional Locations (1)
| const payload = itemData as { items?: SentryMetricPayload[] }; | ||
| if (payload.items && Array.isArray(payload.items)) { | ||
| allMetrics.push(...payload.items); | ||
| } |
There was a problem hiding this comment.
Server-side metrics extraction omits required id field
Medium Severity
The extractMetricsFromEnvelopes function casts raw envelope items to SentryMetricPayload[], but the raw data from envelopes lacks the required id field. The type contract specifies id: string is mandatory, yet raw metric items don't include this field. The UI-side processMetricItems correctly adds IDs, but the server-side MCP tool doesn't, creating an inconsistency.
|
This looks awesome 🤩 |
#1145
reference: https://develop.sentry.dev/sdk/telemetry/metrics/
Screen.Recording.2026-01-25.at.10.40.19.PM.mov