Merged
Conversation
Dav1dde
approved these changes
Feb 3, 2026
| pub(crate) debug_id: DebugId, | ||
| /// CPU architecture of the object file. | ||
| pub(crate) arch: Arch, | ||
| /// |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archis a type for whichPodis not sound to implement because not every pattern of 32 bits is valid for it. This can be demonstrated by running thetest_header_arch_from_bytestest under miri (before the fix):The test itself uses
unsafe, but only because I can't think of another way to obtain a 4-byte aligned slice ofu8.