feat: Very rough first pass at client libraries #516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work at all yet, but I wanted to get the code imported in one go.
- Add a MetricsBackend like we have in arroyo and our other client libraries. - Attach metrics to the namespace so that it can be read in tasks.
Combine small modules together now that import cycles are gone
Replace django's timezone.now() with datetime.now(tz=UTC)
Needed to add UTC to lots of datetime logic to resolve timezone deltas between frozen times and datetime.now(UTC)
TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClientGet tests passing for TaskbrokerClient
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 20 20
Lines 5893 5893
=======================================
Hits 5238 5238
Misses 655 655 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fewer directories now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rough first pass at extracting the taskworker, scheduler and client libraries out of sentry. A few things are not complete yet:
We'll still need some additions in sentry as silo mode behavior was removed when code was imported here.