Skip to content

Conversation

@androidnisse
Copy link
Contributor

Summary

  • Brings the latest IANA 2025b timezone definitions

Test Plan

  • Checked version.

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

Packaging notes

  • Removed tests as they failed on both current and new version.

**Summary**
- Brings the latest IANA 2025b timezone definitions
install : |
%python3_install
rm -rf $installdir/usr/lib/python%python3_version%/site-packages/pytz/zoneinfo
check : |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the test? If we can run test, it would be prefered. But if it cannot run, better comment the test out and add the comment why it doesn't run. Rather than outright removing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it in the PR. Removed tests as they failed on both current and new version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. So, this used to work. Failed test is probably related to this bug. There is diverged in data between pytz and tzdata package. I would prefer if you add this patch instead of removing the test. Please try adding that patch and running the test again. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails with that patch as well.

@malfisya
Copy link
Member

I don't see any changes you made. Forgot to push?

@androidnisse
Copy link
Contributor Author

I don't see any changes you made. Forgot to push?

I made no changes, answered your question, the info is in the PR. 👍

@Jaredy899
Copy link
Contributor

I was playing around with this and this worked for me...

check      : |
    # Skip test_tzinfo.py tests - incompatible with system zoneinfo (expect bundled data)
    %python3_test pytest3 --ignore=pytz/tests/test_tzinfo.py

@EbonJaeger
Copy link
Member

EbonJaeger commented Dec 8, 2025

Isn't that basically the same as disabling all tests? Or am I thinking of a different file?

@Jaredy899
Copy link
Contributor

Yeah you're right. It does test two other files, docs.py and lazy.py but they're pretty inconsequential for the purpose of the package. So never mind!

@EbonJaeger
Copy link
Member

Fwiw, I also looked at this a few days ago, but I don't know why the tests fail. I don't really see what we're doing different in our packages than Fedora or Arch that would affect it.

@androidnisse
Copy link
Contributor Author

So can this go into now without tests or?

@Staudey
Copy link
Member

Staudey commented Dec 12, 2025

Interestingly I'm also seeing pytz test failures when trying to update python-orjson, but that is with the version currently in the repository

edit: Also fails with the old version of python-orjson, so something has changed since the last update that makes the pytz output wonky.

edit2: Ah, just saw that something close to this behaviour was already mentioned in this discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

5 participants