Skip to content

feishin: Add at v1.0.2 #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HarveyDevel merged 1 commit into from
Dec 30, 2025
Merged

feishin: Add at v1.0.2 #7481

HarveyDevel merged 1 commit into from
Dec 30, 2025

Conversation

@sheepman4267
Copy link
Member

@sheepman4267 sheepman4267 commented Dec 29, 2025

Summary

Test Plan

  • Build and install this package on a Solus Plasma (Wayland) system.
  • Note that the icon in kicker is correct, and the same correct icon works in the task switcher.
  • Note that the program is functional.
  • Follow the help-center docs on testing appstream metainfo and note that it completes successfully.

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@github-project-automation github-project-automation bot moved this to Triage in Solus Dec 29, 2025
@sheepman4267 sheepman4267 changed the title feishin: Add at v1.0.1 feishin: Add at v1.0.2 Dec 29, 2025
@sheepman4267 sheepman4267 marked this pull request as ready for review December 29, 2025 05:05
HarveyDevel
HarveyDevel requested changes Dec 29, 2025
View reviewed changes
EbonJaeger
EbonJaeger reviewed Dec 29, 2025
View reviewed changes
@sheepman4267 sheepman4267 force-pushed the feishin branch 2 times, most recently from 48b870e to 53377c7 Compare December 30, 2025 00:59
HarveyDevel
HarveyDevel previously approved these changes Dec 30, 2025
View reviewed changes
EbonJaeger
EbonJaeger reviewed Dec 30, 2025
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also install the main license file with %install_license LICENSE?

@sheepman4267
feishin: Add at v1.0.2
9275cd7 
**Summary**
- Resolves #7477
@sheepman4267
Copy link
Member Author

sheepman4267 commented Dec 30, 2025

Could you also install the main license file with %install_license LICENSE?

Yes, I could!

EbonJaeger
EbonJaeger approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@HarveyDevel HarveyDevel merged commit 49edce6 into main Dec 30, 2025
1 check passed
@HarveyDevel HarveyDevel deleted the feishin branch December 30, 2025 21:28
@github-project-automation github-project-automation bot moved this from Triage to Done in Solus Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EbonJaeger EbonJaeger EbonJaeger approved these changes

@HarveyDevel HarveyDevel HarveyDevel left review comments

Assignees

No one assigned

Labels

None yet

Projects

Solus
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feishin

4 participants

@sheepman4267 @EbonJaeger @HarveyDevel