Skip to content

feat(registries): allow for anonymous LSCR/TrueForge and move TrueForge to default to Quay backend #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrivatePuffin wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −10
Open

feat(registries): allow for anonymous LSCR/TrueForge and move TrueForge to default to Quay backend #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions app/registries/providers/lscr/Lscr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@ const Ghcr = require('../ghcr/Ghcr');
*/
class Lscr extends Ghcr {
getConfigurationSchema() {
return this.joi.object().keys({
username: this.joi.string().required(),
token: this.joi.string().required(),
});
return this.joi.alternatives([
this.joi.string().allow(''),
this.joi.object().keys({
username: this.joi.string().required(),
token: this.joi.string().required(),
}),
]);
}

/**
Expand Down
19 changes: 13 additions & 6 deletions app/registries/providers/trueforge/trueforge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
const Ghcr = require('../ghcr/Ghcr');
const Quay = require('../quay/Quay');

/**
* Linux-Server Container Registry integration.
*/
class Trueforge extends Ghcr {
class Trueforge extends Quay {
getConfigurationSchema() {
return this.joi.object().keys({
username: this.joi.string().required(),
token: this.joi.string().required(),
});
return this.joi.alternatives([
// Anonymous configuration
this.joi.string().allow(''),

// Auth configuration
this.joi.object().keys({
namespace: this.joi.string().required(),
account: this.joi.string().required(),
token: this.joi.string().required(),
}),
]);
}

/**
Expand Down