fix(docker-compose-trigger): only update on tag-change#860
Open
PrivatePuffin wants to merge 1 commit intogetwud:mainfrom
Open
fix(docker-compose-trigger): only update on tag-change#860PrivatePuffin wants to merge 1 commit intogetwud:mainfrom
PrivatePuffin wants to merge 1 commit intogetwud:mainfrom
Conversation
|
This has been independently implemented in WUD-CE as of 9.0.0-ce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs some thorough review, as it also refactored a few things.
But in general this PR should ensure that when a container in a docker-compose file isn't altered in the file, it doesn't update/refresh the running container either.
The docker-compose trigger, should still refresh/update running containers to match the compose file.
But it shouldnt act like the
dockertrigger on other containers.If people want that behavior, they can set-up the docker-trigger isntead.
Fixes: #780