Closed
Conversation
- Attempting to run regex on boolean field: container.image.tag.semver - Throwing instead of returning filtered list of tags
BUG: The logic calling `isDigestToWatch` should pass parsedImage but instead is passing the domain CHANGE: The label `wud.watch.digest` should be respected regardless of registry
Contributor
Author
|
Closing this PR as the fixes contained within have been included with #893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mix of PRs that were merged recently had the following issues:
PR #840
PR #841
container.image.tag.semverPR #842
isDigestToWatchshould pass parsedImage but instead is passing the domain which causes a NPEwud.watch.digestshould be respected regardless of registry (it's up to the user to deal with rate-limiting)Adding unit test coverage to protect against regressions in these areas.