Skip to content

Conversation

@pubkey
Copy link

@pubkey pubkey commented Nov 23, 2023

This PR changes the build scripts so that this package can be used either as esm module or as cjs package at the same time.

This fixes #21 while making it still usable for everyone who is still on cjs modules.

Questions:

  • Would you accept a PR to add a CI via github actions with some tests?
  • Would you accept a PR to add typescript typings (or even rewrite the code to typescript)?
  • Would you accept a PR to have a node.js fallback where the global window variable is not defined?

@zalo
Copy link

zalo commented Dec 31, 2024

@gfodor What do you think of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vite complains

2 participants