-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Rework of wgpu_hal
vulkan buffer importing
#7824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cwfitzgerald
merged 11 commits into
gfx-rs:trunk
from
SupaMaggie70Incorporated:hal_vulkan_buffer_constructor
Jul 9, 2025
Merged
Rework of wgpu_hal
vulkan buffer importing
#7824
cwfitzgerald
merged 11 commits into
gfx-rs:trunk
from
SupaMaggie70Incorporated:hal_vulkan_buffer_constructor
Jul 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
cwfitzgerald
requested changes
Jun 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No real problems, just some questions/notes
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
All comments should be addressed :) |
@cwfitzgerald Bump :) |
cwfitzgerald
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Discussed briefly with @cwfitzgerald in matrix chat.
Description
wgpu_hal
's vulkan buffer constructor to the buffer typefrom_raw_managed
, so that the buffer's memory can be managed bywgpu
rather than externallyTesting
Currently no testing. I don't believe there is any testing for the existing work either however.
Squash or Rebase?
Either works, there is only one commit at the moment.
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.