DepthStencilState validation fixes#8840
Conversation
|
(Responding to discussion of a possible A data point: https://github.com/search?q=language%3ARust+RenderPipelineDescriptor+DepthStencilState&type=code finds 6.7k files 😬. Even the need to add |
aff5f3b to
5196d9a
Compare
|
@cwfitzgerald you had proposed a different change that would create a separate (And I guess separately from that, there's also a question of whether to offer a migration via |
5196d9a to
e78b04a
Compare
|
I'm definitely still on the team of "lets eat the breaking change now" - maybe we can talk about this at the meeting briefly, but I'm not sure what the ideal solution here is, I've offloaded all the context. I think this should probably just go ahead, not blocked on me. |
e78b04a to
b411b3d
Compare
These fields are optional in the WebGPU API. Having them optional in the wgpu API as well keeps validation logic centralized in wgpu-core. Fixes gfx-rs#8830
b411b3d to
55aa93d
Compare
|
I removed I removed the |
The depth-related fields are optional in the WebGPU API, and may be omitted when they are not relevant to the configuration. In order to have
wgpu-coreprovide a common implementation of this validation for all the JS clients, this PR makes them optional in wgpu.Testing
Enables some relevant CTS tests.
Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.