fix(naga): Support dual-source blending for SPIR-V shaders#8865
Merged
Wumpf merged 1 commit intogfx-rs:trunkfrom Jan 28, 2026
Merged
fix(naga): Support dual-source blending for SPIR-V shaders#8865Wumpf merged 1 commit intogfx-rs:trunkfrom
Wumpf merged 1 commit intogfx-rs:trunkfrom
Conversation
andyleiserson
force-pushed
the
jj-push-ozqy
branch
from
7d8ffb6 to
406726c
Compare
6 tasks
Wumpf
approved these changes
Jan 28, 2026
Member
Wumpf
left a comment
Wumpf
left a comment
There was a problem hiding this comment.
nice, looks pretty straight forward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse
indexdecorations into theblend_srcbinding property. I modeled this after what the GLSL front-end does. @Wumpf tagging you because it looks like you added that support in GLSL. I'm a bit out of my element here.Fixes #8864
Testing
Tested in
kaswith kas-gui/kas#635. Also adds a snapshot test.Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.