Handling delta.reasoning_content in llama-server's webUI #14997
+33
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
requested changes
Aug 1, 2025
| @@ -40,6 +40,7 @@ export interface Message { | |||
| type: 'text' | 'root'; | |||
| timestamp: number; // timestamp from Date.now() | |||
| role: 'user' | 'assistant' | 'system'; | |||
| reasoningContent?: string; | |||
There was a problem hiding this comment.
We cannot store reasoning content inside the message object - it must be contained inside content. Otherwise, it's impossible to modify assistant message (a planned feature)
There was a problem hiding this comment.
I think this is OK because messages is not supposed to include the reasoning content from assistants. Editing reasoningContent wouldn't have any effect on the conversation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the reasoning content when llama-server is started with
--reasoning-format deepseek(the default). This also improves support for new Qwen3 2507 thinking specific models that do not send a<think>by default.