Skip to content

cuda : support non-contiguous i32 to i32 copy #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cuda : support non-contiguous i32 to i32 copy #17326

wants to merge 2 commits into from
+14 −0

Conversation

@CISC
Copy link
Collaborator

@CISC CISC commented Nov 17, 2025

rel #17004

@CISC CISC requested a review from slaren as a code owner November 17, 2025 16:33
@CISC CISC requested a review from ggerganov November 17, 2025 16:34
@DajanaV DajanaV mentioned this pull request Nov 17, 2025
Open
@github-actions github-actions bot added testing Everything test related Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Nov 17, 2025
@CISC
Copy link
Collaborator Author

CISC commented Nov 17, 2025

@jeffbolznv @0cc4m Looks like Vulkan could do with support too (but at least it didn't crash like CUDA did):
https://github.com/ggml-org/llama.cpp/actions/runs/19436977342/job/55610305113?pr=17326#step:3:7370

@jeffbolznv
Copy link
Collaborator

jeffbolznv commented Nov 17, 2025

I thought Vulkan already supported this, but I'll check what's going on.

@jeffbolznv
Copy link
Collaborator

jeffbolznv commented Nov 17, 2025

@jeffbolznv @0cc4m Looks like Vulkan could do with support too (but at least it didn't crash like CUDA did): https://github.com/ggml-org/llama.cpp/actions/runs/19436977342/job/55610305113?pr=17326#step:3:7370

Fixed in #17328

@CISC
Copy link
Collaborator Author

CISC commented Nov 19, 2025

@slaren gentle ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaren slaren Awaiting requested review from slaren slaren is a code owner

@ggerganov ggerganov Awaiting requested review from ggerganov

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs testing Everything test related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CISC @jeffbolznv