Draft
Conversation
katossky
reviewed
May 7, 2025
| if ( | ||
| !missing(mapping) && !is.list(mapping) && | ||
| !missing(columnsX) && missing(columnsY) | ||
| !missing(columnsX) && missing(columnsY) |
There was a problem hiding this comment.
Try not to submit changes that are only stylistic.
katossky
reviewed
May 7, 2025
|
|
||
| # get plot type information | ||
| dataTypes <- plot_types(data, columnsX, columnsY, allowDiag = FALSE) | ||
| dataTypes <- GGally:::plot_types(data, columnsX, columnsY, allowDiag = FALSE) |
There was a problem hiding this comment.
Do not use GGally:: form within the GGally package.
|
If I understand correctly there was actually no problem with the fill / colour attribute, but the issue was only caused by the impossibility to "group" by a continuous variable on the diagonal ? |
|
Link to #505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #505
Our new version of the package, created with @melanielacour, enables the generation of new plots on the diagonal within the
ggpairs()function. Specifically, when callingggpairs()with a continuous mapping variable and the argumentdiag = list(continuous = "ridgeDiag"), it will return the usual classic plot, but with the diagonal displaying a density decomposition based on the continuous variable.