Add support for ignore_local_clock #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments? |
There was a problem hiding this comment.
instead of commenting it out, the line should be removed. The test would then be
it { should contain_file('ntp_conf').without_content(/^\s*fudge/) }
|
It needs a test that shows failure if ignore_local_clock is set to an incorrect type, like an array. |
There was a problem hiding this comment.
remove the commented out lines and the else statement. This seems to be the reverse of your logic since the default you specify is false, so these lines would not be there. I think your logic should likely be <% if @my_ignore_local_clock == false -%>
|
Can you point to any articles that explain these options being related to ignoring the local clock? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.