Skip to content

Interface configuration #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Interface configuration #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5ca8d72
Adding interface configuration
simher Jan 13, 2016
6445972
Updated README.md and moved comment for interface configuration
simher Jan 13, 2016
fbf7909
Typo fix
simher Jan 13, 2016
acdae10
Was missing an end..
simher Jan 13, 2016
91c7376
End at wrong place
simher Jan 13, 2016
5c8ec06
Cleanup, was a bit messy with the comments
simher Jan 13, 2016
1df76ca
Moved the comment outside the loop
simher Jan 13, 2016
b545051
Fixing output
simher Jan 13, 2016
0bc656a
Let's skip that newline shall we
simher Jan 14, 2016
80a7bc2
Looping through array, since if we dont stuff breaks...
Sep 27, 2016
ecef543
Merge pull request #1 from marulkan/master
simher Sep 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,9 @@ disable_monitor
Adds 'disable monitor' line - disables NTP Monlist command, useful to prevent NTP reflection attack https://isc.sans.edu/forums/diary/NTP+reflection+attack/17300

- *Default*: false

interface
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interfaces, plural.

---------------
Adds 'interface' line - interface configuration, see man ntp_misc
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not that this must be an array of strings and give an example.


- *Default*: 'UNSET'
1 change: 1 addition & 0 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
$disable_monitor = true,
$sysconfig_path = 'USE_DEFAULTS',
$sysconfig_options = 'USE_DEFAULTS',
$interface = 'UNSET',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of UNSET we could use {}

) {

# validate type as array or fail
Expand Down
7 changes: 6 additions & 1 deletion templates/ntp.conf.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ filegen clockstats file clockstats type day enable
# pool: <http://www.pool.ntp.org/join.html>

<% @servers.each do |server| -%>
server <%= server %><% if @server_options != 'UNSET' %> <%= @server_options %><% end %>
server <%= server %><% if @server_options != 'UNSET' %> <% @server_options.each do |option| -%><%= option %><% end -%><% end %>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is separate from adding the interface parameter and should be in its own pull request.

I noticed you are using your master branch instead of creating a topic branch. Suggest creating a topic branch so this can be separate from the interface pull request (PR).

<% end -%>

<% if @my_peers != ['UNSET'] -%>
Expand Down Expand Up @@ -116,3 +116,8 @@ tinker panic 0
# Disabling monitor - https://isc.sans.edu/diary/NTP+reflection+attack/17300
disable monitor
<% end -%>

<% if @interface != 'UNSET' %>
# Interface configuration <% @interface.each do |value| %>
interface <%= value %><% end %>
<% end %>