feat: return filename in BlockingResponse['redirect']
#4840
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seia-soto
added a commit
to seia-soto/ghostery-extension
that referenced
this pull request
Apr 29, 2025
This is to mitigate CORS issue with base64 redirect uris in ghostery/broken-page-reports#1350. The adblocker release is pending on ghostery/adblocker#4840.
chrmod
reviewed
Apr 30, 2025
| contentType: string; | ||
| dataUrl: string; | ||
| } { | ||
| const resource = this.resourcesByName.get(name) || getResourceForMime(name); |
There was a problem hiding this comment.
we have to add the name to getResourceForMime and the extension will have to generate WARs for those on the build time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies
BlockingResponse['redirect']to havenameproperty to expose the name of resource. By doing this, the user is able to reference a proper web accessible resource URL to return.On ghostery/broken-page-reports#1350,
NS_ERROR_DOM_BAD_URIerrors are reported on redirected resources.