fix: await IDLE loop in email channel disconnect to prevent resource leak#22
Open
jeffklassen wants to merge 2 commits intoghostwright:mainfrom
Open
fix: await IDLE loop in email channel disconnect to prevent resource leak#22jeffklassen wants to merge 2 commits intoghostwright:mainfrom
jeffklassen wants to merge 2 commits intoghostwright:mainfrom
Conversation
…leak startIdleLoop() was fire-and-forget, so disconnect() could return before the loop released the mailbox lock. A rapid disconnect/reconnect cycle could spawn concurrent IDLE loops competing for the same lock. Track the loop promise and await it in disconnect(), and set connectionState before aborting so the loop exits immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnect()can await it before callinglogout()connectionState = "disconnected"before the abort so the loop'swhilecondition exits immediatelyAbortSignal, matching real ImapFlow behaviorWithout this fix, a quick
disconnect()+connect()can spawn a second IDLE loop that competes for the INBOX mailbox lock with the first.Test plan