Conversation
Contributor
Author
|
@giaf I updated the PR (see above), please review and merge, or add comments. |
Contributor
Author
|
@giaf since we're doing pull requests now, any comments on this one? By the way, I wanted to fix the conflicts, but I can't, since you revoked my access since starting this PR. If you want, we can go over them together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been reading up on CMake packages, and as an exercise I rewrote the blasfeo CMake, based on the most current Makefile. You can use it as follows:
For ease of use, I also added the possibility for it to work with the CMake GUI and
ccmake, with drop-down menus for the different choices of target, BLAS implementation etc.UPDATE:
-m64for MKL and-std=c99for BLIS)compile_definitionsinstead of compiler flags leads to robuster builds