Open
Conversation
SchemaEngine.extract_list_fields() converts the achievements array to a Python string representation because the EXPERIENCE schema defines achievements as type: str. The subsequent isinstance() check then fails, causing all bullet points to be silently dropped. Fix by capturing the raw achievements lists from the JSON data before schema extraction, then re-injecting them after processing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tests covering the bug where achievements bullet points were silently dropped during JSON resume import: - Achievements are preserved in form output - Achievement content is not truncated - Achievements formatted as bullet list - Empty achievements handled gracefully - Missing achievements key handled gracefully Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues with Fix: json achievements parsing
Planned Commits