Skip to content

updated workflows#5

Closed
gignsky wants to merge 5 commits intodevelopfrom
feature/review-github-actions
Closed

updated workflows#5
gignsky wants to merge 5 commits intodevelopfrom
feature/review-github-actions

Conversation

@gignsky
Copy link
Copy Markdown
Owner

@gignsky gignsky commented Jul 22, 2025

No description provided.

@gignsky gignsky self-assigned this Jul 22, 2025
@gignsky gignsky requested a review from Copilot July 22, 2025 11:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates GitHub workflow configurations to standardize CI/CD triggers across different workflows and modify Nix build behavior. The changes expand workflow triggers to include more branch patterns and remove manual workflow dispatch while updating Nix command options.

  • Standardized workflow triggers across multiple workflows to include develop, release, hotfix, and bugfix branches
  • Removed manual workflow dispatch trigger from help-to-readme workflow
  • Updated Nix flake check command to use print-build-logs instead of no-build flag

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/help-to-readme.yml Added push triggers for multiple branch patterns and removed workflow_dispatch
.github/workflows/docs.yml Added pull_request triggers for feature branches
.github/workflows/ci-nix.yml Changed Nix flake check from --no-build to --print-build-logs

- develop
- release/*
- hotfix/*
- bugfix/*
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are trailing spaces after the branch pattern. Remove the extra whitespace for consistency.

Suggested change
- bugfix/*
- bugfix/*

Copilot uses AI. Check for mistakes.
experimental-features = nix-command flakes
- name: Run nix flake check
run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --no-build
run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --print-build-logs
Copy link

Copilot AI Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from --no-build to --print-build-logs fundamentally alters the behavior - it now performs builds instead of skipping them. This could significantly increase CI execution time and resource usage. Consider if this change is intentional or if you meant to add --print-build-logs alongside --no-build.

Suggested change
run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --print-build-logs
run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --no-build --print-build-logs

Copilot uses AI. Check for mistakes.
@gignsky gignsky force-pushed the feature/review-github-actions branch from 975ed5c to 1c8306e Compare July 22, 2025 11:47
@gignsky gignsky force-pushed the feature/review-github-actions branch from 9fcf55b to 3059486 Compare July 22, 2025 12:14
@gignsky gignsky closed this Jul 22, 2025
@gignsky gignsky deleted the feature/review-github-actions branch July 22, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants