Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub workflow configurations to standardize CI/CD triggers across different workflows and modify Nix build behavior. The changes expand workflow triggers to include more branch patterns and remove manual workflow dispatch while updating Nix command options.
- Standardized workflow triggers across multiple workflows to include develop, release, hotfix, and bugfix branches
- Removed manual workflow dispatch trigger from help-to-readme workflow
- Updated Nix flake check command to use print-build-logs instead of no-build flag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/help-to-readme.yml | Added push triggers for multiple branch patterns and removed workflow_dispatch |
| .github/workflows/docs.yml | Added pull_request triggers for feature branches |
| .github/workflows/ci-nix.yml | Changed Nix flake check from --no-build to --print-build-logs |
| - develop | ||
| - release/* | ||
| - hotfix/* | ||
| - bugfix/* |
There was a problem hiding this comment.
There are trailing spaces after the branch pattern. Remove the extra whitespace for consistency.
| - bugfix/* | |
| - bugfix/* |
| experimental-features = nix-command flakes | ||
| - name: Run nix flake check | ||
| run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --no-build | ||
| run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --print-build-logs |
There was a problem hiding this comment.
The change from --no-build to --print-build-logs fundamentally alters the behavior - it now performs builds instead of skipping them. This could significantly increase CI execution time and resource usage. Consider if this change is intentional or if you meant to add --print-build-logs alongside --no-build.
| run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --print-build-logs | |
| run: NIX_SKIP_TEMPLATE=1 nix flake check --show-trace --impure --no-build --print-build-logs |
975ed5c to
1c8306e
Compare
9fcf55b to
3059486
Compare
No description provided.