-
Notifications
You must be signed in to change notification settings - Fork 1
IPC 729 changing orientation is changing the header to Your Invoice #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: IPC-716-refactor-for-accessibility
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where changing device orientation incorrectly changes the header title to "Your Invoice" instead of maintaining the appropriate screen title. The fix ensures that the displayed screen state is properly preserved across configuration changes.
- Modified
MutableSharedFlowconfiguration to include replay functionality for better state management - Removed manual title setting logic that was causing inconsistent behavior during orientation changes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GiniHealth.kt | Added replay parameter to _displayedScreen flow to preserve state across configuration changes |
| InvoicesActivity.kt | Removed manual title setting and back stack management code that was causing orientation issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| private val _displayedScreen: MutableSharedFlow<DisplayedScreen> = | ||
| MutableSharedFlow(extraBufferCapacity = 1) | ||
| MutableSharedFlow(replay = 1, extraBufferCapacity = 1) |
Copilot
AI
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding both replay = 1 and extraBufferCapacity = 1 may be redundant. The replay parameter already provides buffering for the last emitted value. Consider using just replay = 1 unless there's a specific need for additional buffer capacity beyond the replayed value.
| MutableSharedFlow(replay = 1, extraBufferCapacity = 1) | |
| MutableSharedFlow(replay = 1) |
obaidgini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks



…Invoice
IPC-729