Skip to content

feat(bank-api-library): Add SonarCloud analysis for each project of monorepo #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MozhganPeivandianSharbaf wants to merge 159 commits into
base: main
Choose a base branch
from
Open

feat(bank-api-library): Add SonarCloud analysis for each project of monorepo #857

MozhganPeivandianSharbaf wants to merge 159 commits into from

Conversation

@MozhganPeivandianSharbaf
Copy link
Contributor

@MozhganPeivandianSharbaf MozhganPeivandianSharbaf commented Nov 3, 2025

PP-2035

@obaidgini
feat(capture-sdk): Adding the unit and integration tests for the user…
22fd9f9 
… Journey feature flag

PP-1700
@obaidgini
feat(capture-sdk): accommodating the co-pilot comments
7210f71 
PP-1700
@obaidgini
Merge branch 'main' of https://github.com/gini/gini-mobile-android in…
811afd4 
…to PP-1700-unit-and-integration-tests
@obaidgini
feat(capture-sdk): refactored the methods of UserAnalyticsEventTracke…
401bf92 
…r to return boolean for better testing

PP-1700
@obaidgini
feat(capture-sdk): refactored the methods of AmplitudeUserAnalyticsEv…
9312a30 
…entTracker to return boolean for better testing

PP-1700
@obaidgini
feat(capture-sdk): refactored the methods of BufferedUserAnalyticsEve…
2463adb 
…ntTracker to return boolean for better testing

PP-1700
@obaidgini
feat(capture-sdk): Changed the comments as per PR comments
e565aea 
PP-1700
@obaidgini
feat(capture-sdk): Changed the tests, according to new refactor and b…
b4fd428 
…ooleans.

PP-1700
@obaidgini
feat(capture-sdk): Changed the setup according to new return type of …
025d397 
…methods

PP-1700
@obaidgini
feat(capture-sdk): Addressing the detekt issues
c2ff476 
PP-1700
@obaidgini
feat(capture-sdk): Resolving the test failures because we changed the…
56bf21f 
… definition of method.

PP-1700
@obaidgini
feat(capture-sdk): Adding a simple SharedPreferenceHelper to store an…
3ec84d7 
…d retrieve strings

PP-1727:
@obaidgini
feat(capture-sdk): Adding a Helper class for all the SAF related work…
95a11d2 
… at one place

PP-1727
@obaidgini
feat(capture-sdk): Adding the switch track color and background, also…
2a4439d 
… the design, this is temporary, will be changed according to new design

PP-1727
@obaidgini
feat(capture-sdk): Adding strings and styles, every item is temporary…
c7e1264 
… and will be changed in next commits

PP-1727
@obaidgini
feat(capture-sdk): Linking the views to java file to initiate flow, w…
8a54d8b 
…ill be changed in next commits

PP-1727
@obaidgini
feat(capture-sdk): Updating the test according to change in createPre…
0b74ecc 
…senter method

PP-1727
@obaidgini
feat(capture-sdk): Adding the ability to remove the SAF data from the…
a94a158 
… app, so the first time behaviour can be initiated again without uninstalling and re-install

PP-1727
@obaidgini
feat(capture-sdk): adding the argument for AnalysisFragment to receiv…
f465a8d 
…e the indication about save invoice feature

PP-1727
@obaidgini
feat(capture-sdk): Adding a default method in callback to open a laun…
103f0d4 
…cher for SAF

PP-1727
@obaidgini
feat(capture-sdk): Adding a method to release education lock, because…
a1962e2 
… in orientation change, the lock was held forever and SDK was going to ANR state

PP-1727
@obaidgini
feat(capture-sdk): Adding the boolean which will inform AnalysisFragm…
c413102 
…entImpl that saving invoices feature is turned off or on

PP-1727
@obaidgini
feat(capture-sdk): Adding required method in the contract of Analysis…
ad639dd 
… presenter related to SAF flow

PP-1727
@obaidgini
feat(capture-sdk): Adding the SAF implementation in the Analysis frag…
da22591 
…ment implementation and presenter

PP-1727
@obaidgini
feat(capture-sdk): Addressing detekt issues
44fbb39 
PP-1727
@obaidgini
feat(capture-sdk): Addressing detekt issues
faa9cd9 
PP-1727
@obaidgini
feat(bank-api-library): Adding backend flag for the saveInvoicesLocally
cdfe337 
PP-1727
@obaidgini
feat(bank-api-library): Adding backend flag for the saveInvoicesLocally
b3ac3b8 
PP-1727
@obaidgini
feat(capture-sdk): Configuring SDK flag in Capture
b3eadd4 
PP-1727
@obaidgini
feat(capture-sdk): Configuring SDK flag in Bank sdk
e5b71d6 
PP-1727
obaidgini and others added 13 commits November 20, 2025 09:37
@obaidgini
ci: update SonarCloud analysis workflow for bank-api-library
69f7431 
PP-2035
@obaidgini
ci: update SonarCloud analysis command for bank-api-library
e6d6c4c 
PP-2035
@obaidgini
ci: fix SonarCloud analysis command for bank-api-library
d6f7d57 
PP-2035
@obaidgini
ci: refactor SonarCloud analysis command for bank-api-library
45a6fc9 
PP-2035
@obaidgini
ci: implement SonarQube analysis workflow for bank-api-library
dac3f4c 
PP-2035
@obaidgini
ci: fix indentation in SonarCloud analysis workflow for bank-api-library
811e729 
PP-2035
@obaidgini
ci: enhance SonarQube analysis workflow for bank-api-library
31a3d76 
PP-2035
@obaidgini
ci: simplify SonarQube scan command for bank-api-library
de2f4b5 
PP-2035
@obaidgini
ci: update SonarQube scan command for bank-api-library
5bd4050 
PP-2035
@obaidgini
ci: downgrade SonarQube plugin version and enhance scan command for b…
a16d046 
…ank-api-library

PP-2035
@MozhganPeivandianSharbaf
feat(bank-sdk): add SonarCloud analysis workflow for bank API library…
fe788fa 
… and SDK

PP-2035
@MozhganPeivandianSharbaf
feat(bank-sdk): add SonarCloud analysis configuration for bank API li…
0992963 
…brary

PP-2035
@MozhganPeivandianSharbaf
feat(bank-sdk): remove specific version for SonarQube plugin in build…
129b800 
….gradle.kts

PP-2035
@MozhganPeivandianSharbaf MozhganPeivandianSharbaf changed the title feat(bank-api-library): Add SonarCloud analysis for bank-api-library feat(bank-api-library): Add SonarCloud analysis for each project of monorepo Dec 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'bank-api-library'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'bank-sdk'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)
4 New Critical Issues (required ≤ 0)
36 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MozhganPeivandianSharbaf
feat(bank-sdk): update SonarCloud project keys and add analysis confi…
eda44a4 
…guration for capture and core API libraries

PP-2035
@MozhganPeivandianSharbaf
feat(capture-sdk): update SonarCloud analysis configuration for core …
fccfb6e 
…API library and capture SDK

PP-2035
@MozhganPeivandianSharbaf
feat(core-api-library): add SonarCloud analysis configuration for ban…
c252450 
…k API library

PP-2035
@MozhganPeivandianSharbaf
feat(bank-sdk): add SonarCloud analysis configuration for health API,…
c37cf33 
… SDK, internal payment, and merchant SDKs

PP-2035
@MozhganPeivandianSharbaf
feat(health-sdk): update SonarCloud build commands for example apps
c6162f0 
PP-2035
@MozhganPeivandianSharbaf
feat(health-sdk): update permissions and add SONAR_TOKEN requirement …
6d36d69 
…for analysis

PP-2035
@MozhganPeivandianSharbaf
feat(health-sdk): update build commands to include clientId and clien…
4ab7964 
…tSecret for Sonar analysis

PP-2035
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-core-api-library'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7 New Critical Issues (required ≤ 0)
18 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-merchant-sdk'

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
1 New Vulnerabilities (required ≤ 0)
1 New Critical Issues (required ≤ 0)
C Security Rating on New Code (required ≥ A)
14 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-health-api-library'

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
1 New Critical Issues (required ≤ 0)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-bank-api-library'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4 New Code Smells (required ≤ 0)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-capture-sdk'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6 New Code Smells (required ≤ 0)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025 •
edited
Loading

Quality Gate Failed Quality Gate failed for 'android-health-sdk'

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Quality Gate Failed Quality Gate failed for 'android-bank-sdk'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
40 New Code Smells (required ≤ 0)
6 New Critical Issues (required ≤ 0)
1 New Bugs (required ≤ 0)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MozhganPeivandianSharbaf MozhganPeivandianSharbaf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MozhganPeivandianSharbaf @obaidgini @abolfazlimahdi