Pp 2180 credit notes feature #865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements a credit note hint feature to complement the existing payment hint functionality. The feature adds a new boolean configuration flag that can be toggled on/off (enabled by default), following the same pattern as the already paid hint and payment due hint features.
Key changes:
- Added
isCreditNoteHintEnabledconfiguration flag across the SDK layers - Updated example app to include UI controls for testing the feature
- Corrected documentation to distinguish "already paid hint" from generic "payment hint"
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java |
Added credit note hint field, getter, and builder method following existing hint feature patterns |
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/Configuration.kt |
Added credit note hint configuration parameter with documentation and corrected "already paid hint" documentation |
bank-sdk/example-app/src/main/res/values/strings.xml |
Added string resource for credit note hint switch label |
bank-sdk/example-app/src/main/res/layout/layout_feature_toggles.xml |
Added SwitchMaterial UI component for credit note hint toggle |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/data/ExampleAppBankConfiguration.kt |
Added credit note hint field to example app configuration data model |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationViewModel.kt |
Wired credit note hint configuration through view model and improved comment clarity |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationActivity.kt |
Added initialization and change listener for credit note hint switch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MozhganPeivandianSharbaf
approved these changes
Dec 10, 2025
Contributor
MozhganPeivandianSharbaf
left a comment
MozhganPeivandianSharbaf
left a comment
There was a problem hiding this comment.
Looks good, Thank you 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.