Pp 1940 sonar qube reduce issues of duplicating literals #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g localization - Add convenience wrapper around `NSLocalizedStringPreferredGiniBankFormat` to improve code readability and reduce verbosity when accessing localized strings throughout the BankSDK PP-1940
…ce duplication of literals PP-1940
…er` to reduce duplication of literals PP-1940
…odel` to reduce duplication of literals PP-1940
…ring localization - Add convenience wrapper around `NSLocalizedStringPreferredFormat` to improve code readability and reduce verbosity when accessing localized strings throughout the GiniCaptureSDK PP-1940
…uplication of literals - use the newly introduced `giniLocalized` method for better visibility and readability PP-1940
…ion of literals PP-1940
…r Strings/Constants/Images PP-1940
…duplication of literals PP-1940
…chant+PaymentComponentsStringsProvider` PP-1940
ValentinaIancu-Gini
had a problem deploying
to
firebase-manual-deploy
GitHub Actions
Error
ValentinaIancu-Gini
had a problem deploying
to
firebase-manual-deploy
GitHub Actions
Error
ValentinaIancu-Gini
had a problem deploying
to
firebase-manual-deploy
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors code to reduce SonarQube issues related to duplicating string literals. The changes extract inline localized strings and image references into centralized private Strings and Images structs within their respective classes, and introduce a new giniLocalized() convenience function to simplify localization calls.
- Introduced
giniLocalized()helper functions in both CaptureSDK and BankSDK as convenience wrappers around the more verbose localization methods - Extracted duplicate string literals into private
Stringsstructs across multiple view controllers and data sources - Refactored QRCode-related classes by extracting
CorrectQRCodeTextContainerandIncorrectQRCodeTextContainerinto separate files with their own string constants - Changed several
enumtypes tostructfor Constants and Images containers (more appropriate since they're just namespaces)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| GiniMerchant+PaymentComponentsStringsProvider.swift | Updated localization comments to be more specific (e.g., "answer 1", "question 1") |
| HelpFormatsDataSource.swift | Major refactoring to use centralized Strings and Images structs instead of inline literals |
| QRCodeOverlay.swift | Extracted nested classes to separate files, added Strings/Images structs |
| IncorrectQRCodeTextContainer.swift | New file containing extracted class with Strings struct |
| CorrectQRCodeTextContainer.swift | New file containing extracted class with Strings struct |
| CameraPreviewView.swift | Removed author attribution comment |
| CameraViewController.swift | Refactored to use Strings struct and new giniLocalized helper |
| AnalysisViewController.swift | Changed Constants from enum to struct |
| GiniCaptureUtils.swift | Added new giniLocalized() convenience function |
| EducationFlowContent.swift | Changed Images from enum to struct |
| SettingsViewController+SwitchOptionModel.swift | Consolidated duplicate return statements using comma-separated case patterns |
| DigitalInvoiceOnboardingViewController.swift | Refactored to use Strings struct and giniLocalized helper |
| DigitalInvoiceHelpViewModel.swift | Refactored to use Strings struct |
| GiniBankUtils.swift | Added new giniLocalized() convenience function |
Comments suppressed due to low confidence (1)
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Camera/Views/QRCodeOverlay/QRCodeOverlay.swift:327
- Typo in comment: "Retrievenig" should be "Retrieving".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ple/GiniBankSDKExample/SettingsViewController/SettingsViewController+SwitchOptionModel.swift
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/ReturnAssistant/Help/DigitalInvoiceHelpViewModel.swift
Outdated
Show resolved
Hide resolved
...ces/GiniBankSDK/Core/ReturnAssistant/Onboarding/DigitalInvoiceOnboardingViewController.swift
Outdated
Show resolved
Hide resolved
...ces/GiniBankSDK/Core/ReturnAssistant/Onboarding/DigitalInvoiceOnboardingViewController.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/ReturnAssistant/Help/DigitalInvoiceHelpViewModel.swift
Show resolved
Hide resolved
...iCaptureSDK/Sources/GiniCaptureSDK/Core/Screens/Help/DataSources/HelpFormatsDataSource.swift
Outdated
Show resolved
Hide resolved
.../GiniBankSDK/Sources/GiniBankSDK/Core/ReturnAssistant/Help/DigitalInvoiceHelpViewModel.swift
Outdated
Show resolved
Hide resolved
ValentinaIancu-Gini
requested a deployment
to
firebase-manual-deploy
GitHub Actions
Waiting
ValentinaIancu-Gini
requested a deployment
to
firebase-manual-deploy
GitHub Actions
Waiting
ValentinaIancu-Gini
requested a deployment
to
firebase-manual-deploy
GitHub Actions
Waiting
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PP-1940
This pull request refactors code to reduce SonarQube issues related to duplicating string literals. The changes extract inline localized strings and image references into centralized private
StringsandImagesstructs within their respective classes, and introduce a newginiLocalized()convenience function to simplify localization calls.giniLocalized()helper functions in both CaptureSDK and BankSDK as convenience wrappers around the more verbose localization methodsStringsstructs across multiple view controllers and data sourcesCorrectQRCodeTextContainerandIncorrectQRCodeTextContainerinto separate files with their own string constantsenumtypes tostructfor Constants and Images containers (more appropriate since they're just namespaces)