Pp 2255 credit note ux flow #1027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qnaveed87
had a problem deploying
to
firebase-manual-deploy
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a credit note hint UX flow that conditionally presents a bottom sheet when a document is identified as a credit note. The implementation adds configuration checks to control when the credit note hint should be displayed.
- Added
determineIfCreditNoteHintEnabledmethod to check both global and client-side feature flags - Introduced
shouldProceedWithCreditNotehelper method to combine credit note detection with hint enablement logic - Updated test helper
ClientConfigurationinitializer to support credit note hint testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift | Adds credit note hint enablement logic and integrates it into the document analysis flow through new helper methods |
| BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift | Adds comprehensive tests for determineIfCreditNoteHintEnabled and updates test helper to support credit note hint configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Show resolved
Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift
Outdated
Show resolved
Hide resolved
|
Base automatically changed from
PP-2243-implement-configuration-switch
to
release/q1-2026-gini-bank
December 19, 2025 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PP-2255
This PR implements a credit note hint UX flow that conditionally presents a bottom sheet when a document is identified as a credit note. The implementation adds configuration checks to control when the credit note hint should be displayed.
Notes for Reviewers