Fix: Remove unused url variable causing double ID in DELETE requests #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
- Line 226 created unused variable: const url = `${action.url}/${row.id}`
- Line 228 correctly used action.url (which already contains the full path with ID from UrlBuilder)
- This inconsistency could cause confusion and potential bugs
Solution:
- Removed the unused url variable construction
- DELETE requests now consistently use action.url which is built by UrlBuilder with all required parameters including the ID
The UrlBuilder automatically extracts the ID from the model (UrlBuilder.php:95-109),
so no manual ID concatenation is needed in the frontend.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
urlvariable that was creating confusion in DELETE request handlingProblem
The datatable component had an inconsistency in DELETE request handling:
const url =${action.url}/${row.id}`` (unused variable)fetch(action.url, {(correctly using action.url)This could potentially cause bugs if developers mistakenly use the
urlvariable instead ofaction.url.Solution
Removed the unused
const urlline. Theaction.urlalready contains the complete path with ID as built byUrlBuilder:->params(['resource' => 'resourceName'])for DELETE actionsTesting
Tested with CouponBuildora delete action:
🤖 Generated with Claude Code