Feature/encryption validation and search improvements #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features:
- RebuildIndex command now checks and encrypts unencrypted fields during rebuild
- Detects non-encrypted data by checking for Laravel's encryption format prefix
- Automatically re-encrypts plaintext data in encrypted cast fields
- Reports number of fields encrypted during rebuild process
- Add encryptedSearchAny() scope for OR logic across multiple fields
- Add encryptedSearchAll() scope for AND logic with multiple field-term pairs
- Both methods support exact and prefix search types
- Compatible with database and Elasticsearch backends
Tests:
- All 106 tests passing
- BatchQueryTest now fully operational with new scope methods
- Rebuild command tested with encryption validation
Technical details:
- Uses getAttributes() to access raw database values
- Detects encrypted format by checking for 'eyJpdiI' prefix (base64 of '{"iv"')
- encryptedSearchAny() delegates to existing encryptedExactMulti/encryptedPrefixMulti
- encryptedSearchAll() builds chained whereIn conditions for AND logic
Improvements:
- Single-field prefix searches now sort by field length (shorter = more relevant)
- Exact matches like "Wilma" will appear before longer matches like "Wilmaaaa"
- Uses LENGTH() function which is compatible across MySQL, PostgreSQL, and SQLite
Technical details:
- Added orderByRaw("LENGTH({$field}) ASC") to scopeEncryptedPrefix
- Multi-field searches remain unsorted due to database function compatibility
- For best results with sorted relevance, use single-field prefix searches
Example:
Client::encryptedPrefix('first_names', 'Wilma')->get()
// Returns: Wilma, Wilmar, Wilmaaaa (sorted by length)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.