Fix Model Assignment During Persona Deliberation in ‘Restaurant’ location (MultiLLM)#6
Open
pedrocurvo wants to merge 1 commit intogiorgiopiatti:mainfrom
Open
Fix Model Assignment During Persona Deliberation in ‘Restaurant’ location (MultiLLM)#6pedrocurvo wants to merge 1 commit intogiorgiopiatti:mainfrom
pedrocurvo wants to merge 1 commit intogiorgiopiatti:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: During deliberations in the “restaurant” location, despite changing the names of the agents, the code would always reference the same model (self.model) because it was not being updated to reflect the next persona’s model.
Solution: Updated the init_persona() method to properly assign and retain the model corresponding to each persona, ensuring that the correct model is used for each agent during deliberations.