Android-#29 Toolbar Setting #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boohyunsik
previously approved these changes
Aug 9, 2019
| android:background="#ffffff" | ||
| android:textSize="50dp" | ||
| android:textColor="#000" | ||
| android:text=" ^^" |
Collaborator
There was a problem hiding this comment.
이 text부분은 어차피 바뀔부분이니까 이런거 추가해주면 다른 사람들이 볼 때 도움이 될 것 같아요
<!-- TODO : This will be changed!! -->
pingoo33
reviewed
Aug 18, 2019
| val tb = findViewById<View>(R.id.app_toolbar) as Toolbar | ||
| val st = findViewById<TextView>(R.id.startText) | ||
| val et = findViewById<TextView>(R.id.endText) | ||
| val it = findViewById<TextView>(R.id.infoText) |
Contributor
There was a problem hiding this comment.
findViewById 를 쓰지 마시고
val tb = app_toolbar as Toolbar 이렇게 바꿔주세요.
변수 이름도 tb 보다는 알아볼 수 있도록 바꿔주세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
툴바 출발 도착에 toast로 메시지가 떠요 각각 start , end
information 부분에도 toast 메시지 info
다 textview로 만들어서 information 버튼이 ^^이걸로 되어있어요