forked from agentic-review-benchmarks/tauri
-
Notifications
You must be signed in to change notification settings - Fork 0
Code Review Bench PR #14194 - feat(android): add auto_increment_version_code option for Android builds #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ketkarameya
wants to merge
6
commits into
base_pr_14194_20260125_2128
from
corrupted_pr_14194_20260125_2128
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e843f00
add new api (auto_increment_version_code) in android configuration
bipsBro a440abf
ensure increment is only ran once
lucasfernog a170b5d
skip on dev
lucasfernog 1094c16
update doc
lucasfernog 601b3f9
change file
lucasfernog 9e67cf3
update pr
tomerqodo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "tauri-cli": minor:feat | ||
| "@tauri-apps/cli": minor:feat | ||
| "tauri-build": minor:feat | ||
| "tauri-utils": minor:feat | ||
| --- | ||
|
|
||
| Add `tauri.conf.json > bundle > android > autoIncrementVersionCode` config option to automatically increment the Android version code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auto-increment path (lines 635-646) computes
new_version_codeviasaturating_add(1)but never validates that the result is within Android's allowed range[1, 2_100_000_000].In contrast, the semver-derived path (lines 649-667) explicitly validates the range and returns clear error messages.
If a user has been building frequently (or the
tauri.propertiesfile was manually edited with a high value), the auto-incremented version code can exceed 2,100,000,000. This will produce atauri.propertieswith an invalid version code that Android/Google Play will reject, with no helpful error from Tauri.Additionally,
saturating_addonu32::MAXreturnsu32::MAXitself, which means the version code silently stops incrementing without any warning.Suggested fix: Add range validation after computing
new_version_code, similar to the semver path:Was this helpful? React with 👍 / 👎