feat: implement pass 1 desktop-first tauri/pdf vertical slice#37
Merged
gitgrahamdunn merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
apps/desktop(Tauri + React + TypeScript) and foundational packages underpackages/*(shared-types,viewer-core,viewer-pdfjs,persistence-core).@gitplant/viewer-core) and a PDF.js adapter (@gitplant/viewer-pdfjs) that produces image data for pages and exposes the required renderer contract.ErrorBoundary, plus a smalltauriGatewayto invoke native commands.documents,document_revisions,recent_documents), persist metadata, return document bytes, and update page counts.apps/desktop/src/App.test.tsxandapps/desktop/src/components/PdfViewer.test.tsx) and a Rust SQLite schema test inapps/desktop/src-tauri/src/lib.rs, and updatedREADME.mdwith quickstart scripts includingnpm run desktop:devandnpm run desktop:build.Testing
apps/desktop/src/App.test.tsxandapps/desktop/src/components/PdfViewer.test.tsx(UI smoke/unit tests), and a Rust unit testsqlite_schema_supports_document_and_recent_persistenceinapps/desktop/src-tauri/src/lib.rsto validate schema/insert/select basics.npm install,npm test), butnpm installfailed due to registry access (HTTP 403) so JS tests and typecheck could not be executed in this environment.cd apps/desktop/src-tauri && cargo test), butcargo testfailed due to network access errors while fetching crates index (HTTP 403), so Rust tests could not complete here.npm installandcargo testfailures).Codex Task