Draft
Conversation
d9ff1d7 to
135827c
Compare
95b4454 to
73a5bc1
Compare
73a5bc1 to
317e76b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds
distributor.sloppy-quorumopt-in flag.When enabled, writes will succeed if there is a sloppy quorum of ingesters available, providing much higher availability than the default replication strategy.
This is needed to pretend being
Dynamo-style quorum consistency(https://grafana.com/docs/loki/latest/overview/). Else it'sCassandra style quorum consistency.Which issue(s) this PR fixes:
Fixes grafana#3360
Special notes for your reviewer:
Checklist