Add additional SystemWeb HttpRequset properties to C# test stubs

[ewillonermsft]

Add additional HttpRequest properties to the System.Web.cs test stubs.

[michaelnebel]

Uh, thank you for doing this! 😄

[michaelnebel]

Is UserAgent a property? https://learn.microsoft.com/en-us/dotnet/api/system.web.httprequest.useragent?view=netframework-4.8.1

[ewillonermsft]

Thank you for bringing this up, I believe all of these properties need some adjustment (though worked on our side for our unittesting purposes). Please see the latest revision, I believe this better reflects the actual implementation as seen in ReferenceSource: HttpRequest.cs. If this is not correct please let me know and I can provide further changes.

[michaelnebel]

Looks good! And yes, the new signatures matches the signatures from the original implementation!

[michaelnebel]

LGTM!

[michaelnebel]

It looks like the change to the stubs doesn't compile with all the tests.

Failing test

[ewillonermsft]

@michaelnebel I don't have access to see which tests exactly in the "C# Language Tests Linux" pipeline is failing, I have started trying to kick them all off manually locally on my machine but I expect this process to take quite a while. I have found the "TaintedPath.qlref" test is failing which seems to be related to the .expected steps changing from this PR, but if you could provide me a full list so I can verify that would save me some time and hassle. Thank you!

[michaelnebel]

@michaelnebel I don't have access to see which tests exactly in the "C# Language Tests Linux" pipeline is failing, I have started trying to kick them all off manually locally on my machine but I expect this process to take quite a while. I have found the "TaintedPath.qlref" test is failing which seems to be related to the .expected steps changing from this PR, but if you could provide me a full list so I can verify that would save me some time and hassle. Thank you!

Oh, that makes it a lot harder to debug.
It appears that one of the tests that are using the stub is failing as the code no longer compiles (unfortunately we have a mix of tests that purely uses stubs and some that uses a combination of stubs and assemblies).
If you cherry-pick this commit then it should fix the problem with the failing test (I am not allowed to push the changes to your branch).

Thank you for your persistence!