Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Nov 13, 2025

No description provided.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Nov 13, 2025
@jketema jketema marked this pull request as ready for review November 13, 2025 14:47
@jketema jketema requested a review from a team as a code owner November 13, 2025 14:47
Copilot AI review requested due to automatic review settings November 13, 2025 14:47
Copilot finished reviewing on behalf of jketema November 13, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for extracting expanded compiler arguments from response files. When compilers receive arguments like @someFile, they expand the contents of that file. The new compilation_expanded_args table and corresponding QL predicates allow queries to access these expanded arguments.

Key changes:

  • Added compilation_expanded_args table to the database schema for storing expanded compilation arguments
  • Introduced getAnExpandedArgument() and getExpandedArgument(int i) predicates to the Compilation class
  • Provided upgrade/downgrade migration paths for database schema compatibility

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/upgrade.properties Defines upgrade metadata for backward compatibility
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/semmlecode.cpp.dbscheme New schema version with compilation_expanded_args table
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/old.dbscheme Previous schema version without expanded args support
cpp/ql/lib/semmlecode.cpp.dbscheme Updated main schema with new compilation_expanded_args table
cpp/ql/lib/semmle/code/cpp/Compilation.qll Added predicates to access expanded arguments
cpp/ql/lib/change-notes/2025-11-13-expanded.md Documents the new feature for release notes
cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/upgrade.properties Downgrade configuration to remove expanded args table
cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/semmlecode.cpp.dbscheme Schema for downgrade without expanded args

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant