-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C++: Extract the expanded compiler arguments #20831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for extracting expanded compiler arguments from response files. When compilers receive arguments like @someFile, they expand the contents of that file. The new compilation_expanded_args table and corresponding QL predicates allow queries to access these expanded arguments.
Key changes:
- Added
compilation_expanded_argstable to the database schema for storing expanded compilation arguments - Introduced
getAnExpandedArgument()andgetExpandedArgument(int i)predicates to theCompilationclass - Provided upgrade/downgrade migration paths for database schema compatibility
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/upgrade.properties |
Defines upgrade metadata for backward compatibility |
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/semmlecode.cpp.dbscheme |
New schema version with compilation_expanded_args table |
cpp/ql/lib/upgrades/2121ffec11fac265524955fee1775217364d4ca4/old.dbscheme |
Previous schema version without expanded args support |
cpp/ql/lib/semmlecode.cpp.dbscheme |
Updated main schema with new compilation_expanded_args table |
cpp/ql/lib/semmle/code/cpp/Compilation.qll |
Added predicates to access expanded arguments |
cpp/ql/lib/change-notes/2025-11-13-expanded.md |
Documents the new feature for release notes |
cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/upgrade.properties |
Downgrade configuration to remove expanded args table |
cpp/downgrades/1a6854060d5d3ada16c580a29f8c5ce21f3367f8/semmlecode.cpp.dbscheme |
Schema for downgrade without expanded args |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.