Skip to content
This repository was archived by the owner on Feb 5, 2020. It is now read-only.

Comments

Send PONG replies using the parameter sent from the client#91

Open
dequis wants to merge 1 commit intogitterHQ:developfrom
dequis:pong
Open

Send PONG replies using the parameter sent from the client#91
dequis wants to merge 1 commit intogitterHQ:developfrom
dequis:pong

Conversation

@dequis
Copy link
Contributor

@dequis dequis commented Mar 12, 2017

Fixes issues with clients like hexchat not being able to correlate sent pings and displaying them as noise in the server buffer.

  irc-client Rx: PING irc.gitter.im +9s
  irc-client Tx: :irc.gitter.im PONG irc.gitter.im :irc.gitter.im +0ms
  irc-client Rx: PING LAG1489229945904 +19s
  irc-client Tx: :irc.gitter.im PONG irc.gitter.im :LAG1489229945904 +0ms

rfc1459 (but as you can see above, in practice the server2 parameter isn't used as such)

Fixes issues with clients like hexchat not being able to correlate sent
pings and displaying them as noise in the server buffer.
@mydigitalself mydigitalself changed the base branch from master to develop March 22, 2017 12:48
@MaxLeiter
Copy link

Any chance of this being merged?

@MadLittleMods
Copy link
Member

@MaxLeiter This project has moved to GitLab, it will be merged over there https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91 eventually (in the last few weeks, I have been working on Gitter full-time again so hopefully sooner rather than later)

@dequis
Copy link
Contributor Author

dequis commented May 3, 2018

Oh, huh, i had no idea, good to know I guess, enabled notifications over there.

Weirdly enough it seems to have migrated one of my PRs with my gitlab username (dx) but not this one?

Both PRs say the source branch is missing, should I do something about it or will you just merge it from here? It displays the diff properly at least.

@MadLittleMods
Copy link
Member

@dequis We will merge over on GitLab. To restore, we can just apply https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91.diff to a new branch and push it up.

Feel free to create new merge requests so that the author points back to you properly

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants