Send PONG replies using the parameter sent from the client#91
Send PONG replies using the parameter sent from the client#91dequis wants to merge 1 commit intogitterHQ:developfrom
Conversation
Fixes issues with clients like hexchat not being able to correlate sent pings and displaying them as noise in the server buffer.
|
Any chance of this being merged? |
|
@MaxLeiter This project has moved to GitLab, it will be merged over there https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91 eventually (in the last few weeks, I have been working on Gitter full-time again so hopefully sooner rather than later) |
|
Oh, huh, i had no idea, good to know I guess, enabled notifications over there. Weirdly enough it seems to have migrated one of my PRs with my gitlab username (dx) but not this one? Both PRs say the source branch is missing, should I do something about it or will you just merge it from here? It displays the diff properly at least. |
|
@dequis We will merge over on GitLab. To restore, we can just apply https://gitlab.com/gitlab-org/gitter/irc-bridge/merge_requests/91.diff to a new branch and push it up. Feel free to create new merge requests so that the author points back to you properly |
Fixes issues with clients like hexchat not being able to correlate sent pings and displaying them as noise in the server buffer.
rfc1459 (but as you can see above, in practice the server2 parameter isn't used as such)