Add demo showing breaking case for LiveView content updating and potential fix#11
Merged
giusdp merged 3 commits intogiusdp:mainfrom May 6, 2025
Merged
Conversation
Contributor
Author
|
The last commit is a potential fix (it does appear to solve issue #12 ), but I'm not great on JS and not sure if this will create memory leaks etc with your wire-up |
mindok
changed the title
Owner
|
The fix looks pretty good, it just recalculates the style of the element when liveview updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small sample showing a breaking case where LiveView creates a DOM update below a LivePane.pane, causing the style attribute of the div implementing the pane to be removed, so the pane no longer renders correctly. Click on one of the items in the bottom pane to see how it all goes bad.
I'll raise an issue separately. I'm pretty sure the pane hook needs to implement
updated()to recalc and reapply the style - currently they are only applied onmounted().