Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new server-pushed resize event to imperatively resize a pane (by percentage) and includes a Demo LiveView page showcasing the behavior.
Changes:
- Documented server-side events (
collapse,expand,resize) inLivePanemodule docs. - Added a new
resizeserver event handler in the pane JS hook to resize a pane to a target percentage (with clamping). - Added a new demo route + LiveView/page to demonstrate imperative resizing.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/live_pane.ex |
Documents the new resize server event alongside existing server-driven events. |
assets/js/live_pane/hooks/pane.ts |
Implements the client-side handler and layout adjustment logic for server-pushed resize. |
demo/lib/demo_web/router.ex |
Adds a /resize LiveView route in the demo app. |
demo/lib/demo_web/components/layouts.ex |
Adds navigation link to the new resize demo page. |
demo/lib/demo_web/live/resize_live.ex |
Demo LiveView that pushes the resize event from the server. |
demo/lib/demo_web/live/resize_live.html.heex |
Demo UI for selecting a size and triggering the server-side resize. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Hey thanks a ton for the contribution!! Soon I'll review and merge 😄 btw I don't remember enabling any automatic copilot review wtf |
Owner
|
Awesome work, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to implement double click to resize my panes to default.
I didn't find a way to do it, does this implementation follows your philosophy?