Skip to content

refactor: determine if we need updating based on the number of obsolute tests #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-Rath wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: determine if we need updating based on the number of obsolute tests #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions snaps/clean.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,6 @@ func examineSnaps(
return nil, isDirty, err
}

var needsUpdating bool

registeredTests := occurrences(registry[snapPath], count, snapshotOccurrenceFMT)
s := snapshotScanner(f)

Expand All @@ -267,7 +265,6 @@ func examineSnaps(

if !registeredTests.Has(testID) && !testSkipped(testID, runOnly) {
obsoleteTests = append(obsoleteTests, testID)
needsUpdating = true

removeSnapshot(s)
continue
Expand Down Expand Up @@ -297,7 +294,7 @@ func examineSnaps(
// if we're not allowed to update anything, just capture if the snapshot
// needs cleaning, and then continue to the next snapshot
if !shouldUpdate {
if needsUpdating || needsSorting {
if len(obsoleteTests) > 0 || needsSorting {
isDirty = true
}

Expand Down
Loading