Update unit testing to use UV over micromamba for environment management#228
Update unit testing to use UV over micromamba for environment management#228ludwiglierhammer merged 11 commits intoglamod:mainfrom
Conversation
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 76 76
Lines 2817 2817
=======================================
Hits 2373 2373
Misses 444 444
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add python 3.13 Co-authored-by: Ludwig Lierhammer <Ludwig.Lierhammer@dwd.de>
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
Once you have the unit tests running, I would implement a new Github action that tests if the environment creation works with both pip and conda for different Python versions. |
|
py3.9 has failed due to connection problems: In general, the tests are passing 🎉 |
Sure, are you thinking a check similar to And similar for conda? |
Yes, I would create a new yaml file in .github/workflows. |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
I've added a workflow for installation check via pip for py3.11. It creates a conda envrionment with no dependencies (other than the python version). It then installs the library with See https://github.com/glamod/cdm_reader_mapper/actions/runs/13367474700/job/37328361995?pr=228 Thoughts/suggestions? |
|
I did a new PR (#229) regarding exactly this issue. Looks similar to your |
Unfortunately, it is not running at the moment. |
|
@jtsiddons: I updated some dependencies in PR #229 and did some renamings:
Since |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
@ludwiglierhammer: Did the tests change or did I merge main incorrectly? |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
Sorry, my bad. I fixed this. |
I can't think of any. I have no further workflows in my mind. Do you have any specific ideas? |
Co-authored-by: Ludwig Lierhammer <Ludwig.Lierhammer@dwd.de>
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
Looks good to me 👍 |
Co-authored-by: Ludwig Lierhammer <Ludwig.Lierhammer@dwd.de>
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
Yes, gladly. I thought of somethign like this: Announcements |
I would call the new release E.g: 2.0.1 (unreleased)
------------------
Contributors to this version: Ludwig Lierhammer (:user:`ludwiglierhammer`) and Joseph Siddons (:user:`jtsiddons`)
Announcements
^^^^^^^^^^^^^
This release drops support for Python 3.9 and adds support for Python 3.13 (:pull:`228`, :pull:`229`)
New features and enhancements
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
* add environment.yml file (:pull:`229`)
Internal changes
^^^^^^^^^^^^^^^^
* GitHub workflow for ``testing_suite`` now uses ``uv`` for environment management, replacing ``micromamba`` (:pull:`228`)
* rename ci/requirements to CI and tidy up requirements/dependencies (:pull:`229`)edits: add example and pull ref |
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
Co-authored-by: Ludwig Lierhammer <Ludwig.Lierhammer@dwd.de>
|
Warning This Pull Request modifies GitHub Workflows and is coming from a fork. |
|
Looks good to me. Thanks for your work. Anything to add from your side? Can I merge this PR? |
I think so. I can't think of anything to add immediately. |
See https://docs.astral.sh/uv/guides/integration/github/