Fix git:branch bug when there is more than one branch with equal SHA-ID

[mrjaros]

This fixes badmatch error when we have more than one branch with equal sha-id. In such case, you tried to match one-element list ([B]) with list of branches (["branchA", "branchB"]). Now we just return list of branches, separated with "; ", ex. "branchA; branchB"

[gleber]

Use string:join/2 instead

[mrjaros]

good point

[mrjaros]

hmm, how about just

branch(Repo) ->
    case status_is_detached(Repo) of
        false ->
            {ok, B} = sh("git rev-parse --abbrev-ref HEAD", [{cd, Repo}]),
            B--"\n";
        true ->
            detached
    end.

[flycodepl]

-spec branch(dir()) -> {'ok', branch()} | 'detached'.
branch(Repo) ->
    case status_is_detached(Repo) of
        false ->
            CurrentBranch = strip(oksh("git symbolic-ref --short HEAD", [{cd, Repo}])),
            {ok, CurrentBranch};
        true ->
            detached
    end.

And if you don't want to use

git symbolic-ref --short HEAD

see other options: http://stackoverflow.com/a/19585361

[mrjaros]

Good idea to use oksh with strip. I've missed it.

[gleber]

This is incorrect. -include_lib automatically finds an application "erlsemver" (even if it located in a folder name with version number) and will find include/semver.hrl from there.

In general -include_lib is preferred over -include.

If you really need to use brute force relative path, use -include.

[mrjaros]

True, my bad, homie. I used this to make c(module) possible, committed and pushed accidentally. Trash it.

[gleber]

Can't trash it on my side. Delete it from PR, so I can merge it :)